fix: fix badge replacement (#232)

all-contributors · Dec 9, 2019 · dbb05a4 · dbb05a4
1 parent 3382821
commit dbb05a4
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -12,3 +12,4 @@ package-lock.json
 yarn.lock
 .vscode
 cache
+.idea
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-8.14.0
+8.16.0
diff --git a/src/generate/__tests__/index.js b/src/generate/__tests__/index.js
@@ -143,9 +143,9 @@ test('replace all-contributors badge if present', () => {
     'Badges',
     [
       '[![version](https://img.shields.io/npm/v/all-contributors-cli.svg?style=flat-square)](http://npm.im/all-contributors-cli)',
-      '<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->',
-      '[![All Contributors](https://img.shields.io/badge/all_contributors-0-orange.svg?style=flat-square)](#contributors-)',
-      '<!-- ALL-CONTRIBUTORS-BADGE:END -->',
+      '<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->\n',
+      '[![All Contributors](https://img.shields.io/badge/all_contributors-0-orange.svg?style=flat-square)](#contributors-)\n',
+      '<!-- ALL-CONTRIBUTORS-BADGE:END -->\n',
       '[![version](https://img.shields.io/npm/v/all-contributors-cli.svg?style=flat-square)](http://npm.im/all-contributors-cli)',
     ].join(''),
     '',
@@ -157,9 +157,9 @@ test('replace all-contributors badge if present', () => {
     'Badges',
     [
       '[![version](https://img.shields.io/npm/v/all-contributors-cli.svg?style=flat-square)](http://npm.im/all-contributors-cli)',
-      '<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->',
-      '[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)',
-      '<!-- ALL-CONTRIBUTORS-BADGE:END -->',
+      '<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->\n',
+      '[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)\n',
+      '<!-- ALL-CONTRIBUTORS-BADGE:END -->\n',
       '[![version](https://img.shields.io/npm/v/all-contributors-cli.svg?style=flat-square)](http://npm.im/all-contributors-cli)',
     ].join(''),
     '',

diff --git a/src/generate/index.js b/src/generate/index.js
@@ -81,7 +81,9 @@ function replaceBadge(newContent) {
     }
     return [
       previousContent.slice(0, endOfOpeningTagIndex + closingTag.length),
+      '\n',
       newContent,
+      '\n',
       previousContent.slice(startOfClosingTagIndex),
     ].join('')
   }