Skip to content

Commit

Permalink
Upgrade to ESLint 6 (#235)
Browse files Browse the repository at this point in the history
* Upgrade to ESLint 6

* Update minimum Node.js version to match ESLint

* Upgrade to 6.0.0

* Fix some tests

* Fix `options.warnFileIgnored`

* Fix test

* Update CHANGELOG
  • Loading branch information
ehmicky authored and shinnn committed Jun 28, 2019
1 parent 40d004f commit a35a203
Show file tree
Hide file tree
Showing 7 changed files with 393 additions and 390 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
@@ -1,7 +1,7 @@
language: node_js
node_js:
- node
- '6'
- '8.10.0'
before_install: npm install --global npm
script: npm run-script pretest && npm run-script coverage
after_script: npx coveralls < coverage/lcov.info
5 changes: 5 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,10 @@
# Changelog

## 6.0.0

* Bump `eslint` dependency to ^6.0.0 <https://eslint.org/blog/2019/06/eslint-v6.0.0-released>
* Drop support for Node 6 and 7

## 5.0.0

* Bump `eslint` dependency to ^5.0.0 <https://eslint.org/blog/2018/06/eslint-v5.0.0-released>
Expand Down
2 changes: 1 addition & 1 deletion index.js
Expand Up @@ -48,7 +48,7 @@ function gulpEslint(options) {
// E.g., If ../.eslintignore has "foo/*.js", ESLint will ignore ./foo/*.js, instead of ../foo/*.js.
// Eslint rolls this into `CLIEngine.executeOnText`. So, gulp-eslint must account for this limitation.

if (linter.options.ignore && options.warnFileIgnored) {
if (linter.isPathIgnored(filePath) && options.warnFileIgnored) {
// Warn that gulp.src is needlessly reading files that ESLint ignores
file.eslint = createIgnoreResult(file);
}
Expand Down

0 comments on commit a35a203

Please sign in to comment.