Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed check for RPC JSON response success [v1.0] #977

Merged
merged 1 commit into from Apr 26, 2022

Conversation

poriyaalarsamvelraja
Copy link
Contributor

Fixes #930

According to RPC JSON format 2.0

This member MUST NOT exist if there was an error invoking the method.

The condition if(payload.result) would fail if the result is null which is true for many success cases.

for example for wallet_switchEthereumChain

@poriyaalarsamvelraja
Copy link
Contributor Author

Thanks @pedrouid

@pedrouid
Copy link
Member

@poriyaalarsamvelraja I have published v1.7.8 with these changes

@poriyaalarsamvelraja
Copy link
Contributor Author

Thanks Mate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants