Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle JSON-RPC Error data #1151

Merged
merged 4 commits into from Aug 2, 2022
Merged

Handle JSON-RPC Error data #1151

merged 4 commits into from Aug 2, 2022

Conversation

pedrouid
Copy link
Member

Fix #1000

@pedrouid pedrouid changed the base branch from v2.0 to v1.0 June 11, 2022 16:05
@pedrouid
Copy link
Member Author

Published a release candidate under next tag with version 1.8.0-rc.0

@pedrouid pedrouid marked this pull request as ready for review June 11, 2022 16:05
@pedrouid pedrouid mentioned this pull request Jun 11, 2022
Closed
@bkrem bkrem mentioned this pull request Jun 11, 2022
Closed
xzilja
xzilja approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you scroll further down in the pr, github picked up a bunch of unused vars. Not sure if they are needed, but if not they can prob be cleaned up.

bkrem
bkrem requested changes Jun 14, 2022
View reviewed changes
packages/helpers/qrcode-modal/package.json Outdated Show resolved Hide resolved
@bkrem bkrem merged commit e4432dc into v1.0 Aug 2, 2022
@arein arein deleted the error-data branch August 4, 2022 09:21
@arein arein restored the error-data branch August 4, 2022 09:21
@renovate renovate bot mentioned this pull request Jun 15, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzilja xzilja xzilja approved these changes

@bkrem bkrem bkrem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet Connect not exposing error.data when custom error is thrown
3 participants
@pedrouid @xzilja @bkrem