fix: readDir will check if passed path is a directory (#464)

✅ Closes: #462
TypeStrong · Jun 24, 2020 · ad0eac9 · ad0eac9
1 parent 5b59691
commit ad0eac9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/typescript-reporter/file-system/PassiveFileSystem.ts b/src/typescript-reporter/file-system/PassiveFileSystem.ts
@@ -24,15 +24,19 @@ function createPassiveFileSystem(caseSensitive = false, realFileSystem: FileSyst
   }
 
   function memReadFile(path: string, encoding?: string): string | undefined {
-    if (memExists(path)) {
+    const stats = memReadStats(path);
+
+    if (stats && stats.isFile()) {
       return mem
         .readFileSync(normalizePath(path), { encoding: encoding as BufferEncoding })
         .toString();
     }
   }
 
   function memReadDir(path: string): Dirent[] {
-    if (memExists(path)) {
+    const stats = memReadStats(path);
+
+    if (stats && stats.isDirectory()) {
       return mem.readdirSync(normalizePath(path), { withFileTypes: true }) as Dirent[];
     }
 

diff --git a/src/typescript-reporter/file-system/RealFileSystem.ts b/src/typescript-reporter/file-system/RealFileSystem.ts
@@ -48,7 +48,9 @@ function createRealFileSystem(caseSensitive = false): FileSystem {
     const normalizedPath = normalizePath(path);
 
     if (!readFileCache.has(normalizedPath)) {
-      if (exists(normalizedPath)) {
+      const stats = readStats(normalizedPath);
+
+      if (stats && stats.isFile()) {
         readFileCache.set(normalizedPath, fs.readFileSync(normalizedPath, { encoding }).toString());
       } else {
         readFileCache.set(normalizedPath, undefined);
@@ -62,7 +64,9 @@ function createRealFileSystem(caseSensitive = false): FileSystem {
     const normalizedPath = normalizePath(path);
 
     if (!readDirCache.has(normalizedPath)) {
-      if (exists(normalizedPath)) {
+      const stats = readStats(normalizedPath);
+
+      if (stats && stats.isDirectory()) {
         readDirCache.set(normalizedPath, fs.readdirSync(normalizedPath, { withFileTypes: true }));
       } else {
         readDirCache.set(normalizedPath, []);