fix: support webpack multi-compiler (#431)

✅ Closes: #426
TypeStrong · May 28, 2020 · 503a948 · 503a948
1 parent 9b3b9dd
commit 503a948
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/src/hooks/tapAfterCompileToGetIssues.ts b/src/hooks/tapAfterCompileToGetIssues.ts
@@ -13,6 +13,11 @@ function tapAfterCompileToGetIssues(
   const hooks = getForkTsCheckerWebpackPluginHooks(compiler);
 
   compiler.hooks.afterCompile.tapPromise('ForkTsCheckerWebpackPlugin', async (compilation) => {
+    if (compilation.compiler !== compiler) {
+      // run only for the compiler that the plugin was registered for
+      return;
+    }
+
     let issues: Issue[] | undefined = [];
 
     try {

diff --git a/src/hooks/tapDoneToAsyncGetIssues.ts b/src/hooks/tapDoneToAsyncGetIssues.ts
@@ -17,6 +17,11 @@ function tapDoneToAsyncGetIssues(
   const hooks = getForkTsCheckerWebpackPluginHooks(compiler);
 
   compiler.hooks.done.tap('ForkTsCheckerWebpackPlugin', async (stats) => {
+    if (stats.compilation.compiler !== compiler) {
+      // run only for the compiler that the plugin was registered for
+      return;
+    }
+
     const report = state.report;
     let issues: Issue[] | undefined;
 

diff --git a/src/hooks/tapDoneToCollectRemoved.ts b/src/hooks/tapDoneToCollectRemoved.ts
@@ -9,6 +9,11 @@ function tapDoneToCollectRemoved(
   state: ForkTsCheckerWebpackPluginState
 ) {
   compiler.hooks.done.tap('ForkTsCheckerWebpackPlugin', (stats) => {
+    if (stats.compilation.compiler !== compiler) {
+      // run only for the compiler that the plugin was registered for
+      return;
+    }
+
     state.removedFiles = [];
 
     // the new watcher is defined after done hook

diff --git a/src/hooks/tapStartToConnectAndRunReporter.ts b/src/hooks/tapStartToConnectAndRunReporter.ts
@@ -18,7 +18,7 @@ function tapStartToConnectAndRunReporter(
 ) {
   const hooks = getForkTsCheckerWebpackPluginHooks(compiler);
 
-  compiler.hooks.run.tap('ForkTsCheckerWebpackPlugin', (compiler) => {
+  compiler.hooks.run.tap('ForkTsCheckerWebpackPlugin', () => {
     if (!state.initialized) {
       state.initialized = true;
 
@@ -27,7 +27,7 @@ function tapStartToConnectAndRunReporter(
     }
   });
 
-  compiler.hooks.watchRun.tap('ForkTsCheckerWebpackPlugin', async (compiler) => {
+  compiler.hooks.watchRun.tap('ForkTsCheckerWebpackPlugin', async () => {
     if (!state.initialized) {
       state.initialized = true;
 
@@ -42,6 +42,11 @@ function tapStartToConnectAndRunReporter(
   });
 
   compiler.hooks.compilation.tap('ForkTsCheckerWebpackPlugin', async (compilation) => {
+    if (compilation.compiler !== compiler) {
+      // run only for the compiler that the plugin was registered for
+      return;
+    }
+
     let change: FilesChange = {};
 
     if (state.watching) {