Skip to content

Commit

Permalink
Merge pull request #6373 from ReactiveX/export-internal
Browse files Browse the repository at this point in the history
build(package): support internal subpath import
  • Loading branch information
kwonoj committed May 7, 2021
2 parents aa9c3d4 + 5fcedd4 commit 68210d7
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .eslintrc
Expand Up @@ -106,6 +106,10 @@
"hot": true,
"cold": true
},
"parserOptions": {
"sourceType": "module",
"ecmaVersion": 2015
},
"env": {
"browser": true,
"node": true,
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -32,6 +32,7 @@ spec-build/
npm-debug.log
.DS_STORE
*.tgz
.eslintcache

integration/import/**/rx.json
integration/import/**/operators.json
Expand Down
5 changes: 4 additions & 1 deletion integration/import/fixtures/commonjs/index.js
Expand Up @@ -6,8 +6,11 @@ const operators = require('rxjs/operators');
const rxSnapshot = require('./rx.json');
const operatorsSnapshot = require('./operators.json');

const coldObservalbe = require('rxjs/internal/testing/ColdObservable');

assert.ok(rx, 'main export should exists');
assert.ok(operators, 'operator export should exists');
assert.ok(coldObservalbe, 'internal can be imported');

assert.deepStrictEqual(Object.keys(rx).sort(), rxSnapshot.sort(), 'main export should include exports');
assert.deepStrictEqual(Object.keys(operators).sort(), operatorsSnapshot.sort(), 'operator export should include exports');
assert.deepStrictEqual(Object.keys(operators).sort(), operatorsSnapshot.sort(), 'operator export should include exports');
10 changes: 8 additions & 2 deletions package.json
Expand Up @@ -8,7 +8,9 @@
"types": "index.d.ts",
"typesVersions": {
">=4.2": {
"*": ["dist/types/*"]
"*": [
"dist/types/*"
]
}
},
"sideEffects": false,
Expand Down Expand Up @@ -37,6 +39,10 @@
"node": "./dist/cjs/webSocket/index.js",
"default": "./dist/esm5/webSocket/index.js"
},
"./internal/*": {
"node": "./dist/cjs/internal/*.js",
"default": "./dist/esm5/internal/*.js"
},
"./package.json": "./package.json"
},
"config": {
Expand Down Expand Up @@ -216,4 +222,4 @@
"commit-msg": "validate-commit-msg"
}
}
}
}

0 comments on commit 68210d7

Please sign in to comment.