Made Autoloader and Diff Highlight compatible #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2577.
I fixed the issue by making two changes:
diff-xxxxformat, andPrism.languages.diffat "run time".Up until now, DH used to read the
PREFIXESproperty fromPrism.languages.diffduring the initialization of the plugin. This meant that the Diff language definition always had to be loaded before DH. This is no longer the case meaning that the Diff language definition can be loaded async (Autoloader) and DH will work. Without Diff loaded, DH will do (almost) nothing and log a one-time warning saying that it requires the Diff language definition (the warning will be suppressed if Autoloader is present).I also made some other very minor changes to DH.