feat: sort p2sh signatures for multisig (#369)

* feat: sort signatures for p2sh txs

src/new/wallet.js

@@ -391,8 +391,12 @@ class HathorWallet extends EventEmitter {
     const multisigData = accessData.multisig;
     const xpub = HDPublicKey(accessData.xpubkey);
 
-    // deserialize P2SHSignature for all signatures
-    const p2shSignatures = signatures.map(sig => P2SHSignature.deserialize(sig));
+    // Deserialize P2SHSignature for all signatures
+    // XXX: the .sort here is very important since the fullnode requires the signatures
+    // in the same order as the pubkeys in the redeemScript and the order chosen for the
+    // pubkeys is the order of the sorted account path pubkey (hex encoded). This sort
+    // only works because the serialized signature starts with the account path pubkey.
+    const p2shSignatures = signatures.sort().map(sig => P2SHSignature.deserialize(sig));
 
     for (const {index, input} of tx.inputs.map((input, index) => ({index, input}))) {
       if (!(input.hash in historyTransactions)) {

src/utils/wallet.ts

@@ -388,8 +388,15 @@ const wallet = {
       throw new Error('Signatures are incompatible with redeemScript');
     }
     const arr: Buffer[] = [];
+    let sigCount = 0;
     for (const sig of signatures) {
       helpers.pushDataToStack(arr, sig);
+      if (++sigCount >= minSignatures) {
+        // XXX: This conditional makes it so signatures after minSignatures are ignored
+        // This is because the OP_CHECKMULTISIG will only acknowledge and verify the minimum
+        // number and treat any excess as extra data on stack
+        break;
+      }
     }
     helpers.pushDataToStack(arr, redeemScript);
     return util.buffer.concat(arr);