role "option" changed to "button", removed unnecessary "listbox" role (…

…#2098) Co-authored-by: DDiaz <daniel.diaz@isobar.com>
Hacker0x01 · Mar 25, 2020 · c1fdd32 · c1fdd32
1 parent 4ae0ca4
commit c1fdd32
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/src/day.jsx b/src/day.jsx
@@ -240,14 +240,15 @@ export default class Day extends React.Component {
 
   getAriaLabel = () => {
     const {
-            day,
-            ariaLabelPrefixWhenEnabled = "Choose",
-            ariaLabelPrefixWhenDisabled = "Not available" 
+      day,
+      ariaLabelPrefixWhenEnabled = "Choose",
+      ariaLabelPrefixWhenDisabled = "Not available"
     } = this.props;
-
-    const prefix = this.isDisabled() || this.isExcluded()
-                    ? ariaLabelPrefixWhenDisabled
-                    : ariaLabelPrefixWhenEnabled;
+
+    const prefix =
+      this.isDisabled() || this.isExcluded()
+        ? ariaLabelPrefixWhenDisabled
+        : ariaLabelPrefixWhenEnabled;
 
     return `${prefix} ${formatDate(day, "PPPP")}`;
   };
@@ -274,7 +275,7 @@ export default class Day extends React.Component {
       onMouseEnter={this.handleMouseEnter}
       tabIndex={this.getTabIndex()}
       aria-label={this.getAriaLabel()}
-      role="option"
+      role="button"
       aria-disabled={this.isDisabled()}
     >
       {this.props.renderDayContents

diff --git a/src/month.jsx b/src/month.jsx
@@ -317,7 +317,6 @@ export default class Month extends React.Component {
       <div
         className={this.getClassNames()}
         onMouseLeave={this.handleMouseLeave}
-        role="listbox"
         aria-label={`${ariaLabelPrefix} ${utils.formatDate(day, "yyyy-MM")}`}
       >
         {showMonthYearPicker