core(inspector-issues): add federatedAuthRequestIssue (#13603)

GoogleChrome · Jan 27, 2022 · e8d6e0f · e8d6e0f
1 parent 2e13357
commit e8d6e0f
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 6 deletions.
diff --git a/lighthouse-core/gather/gatherers/inspector-issues.js b/lighthouse-core/gather/gatherers/inspector-issues.js
@@ -66,6 +66,7 @@ class InspectorIssues extends FRGatherer {
       contentSecurityPolicyIssue: [],
       corsIssue: [],
       deprecationIssue: [],
+      federatedAuthRequestIssue: [],
       genericIssue: [],
       heavyAdIssue: [],
       lowTextContrastIssue: [],

diff --git a/lighthouse-core/test/audits/dobetterweb/inspector-issues-test.js b/lighthouse-core/test/audits/dobetterweb/inspector-issues-test.js
@@ -20,6 +20,7 @@ describe('Has inspector issues audit', () => {
       contentSecurityPolicyIssue: [],
       corsIssue: [],
       deprecationIssue: [],
+      federatedAuthRequestIssue: [],
       genericIssue: [],
       heavyAdIssue: [],
       lowTextContrastIssue: [],

diff --git a/lighthouse-core/test/gather/gatherers/inspector-issues-test.js b/lighthouse-core/test/gather/gatherers/inspector-issues-test.js
@@ -248,6 +248,7 @@ describe('_getArtifact', () => {
       quirksModeIssue: [],
       sharedArrayBufferIssue: [],
       twaQualityEnforcement: [],
+      federatedAuthRequestIssue: [],
     });
   });
 
@@ -303,6 +304,7 @@ describe('_getArtifact', () => {
       quirksModeIssue: [],
       sharedArrayBufferIssue: [],
       twaQualityEnforcement: [],
+      federatedAuthRequestIssue: [],
     });
   });
 });
@@ -363,6 +365,7 @@ describe('FR compat', () => {
       quirksModeIssue: [],
       sharedArrayBufferIssue: [],
       twaQualityEnforcement: [],
+      federatedAuthRequestIssue: [],
     });
   });
 
@@ -398,6 +401,7 @@ describe('FR compat', () => {
       quirksModeIssue: [],
       sharedArrayBufferIssue: [],
       twaQualityEnforcement: [],
+      federatedAuthRequestIssue: [],
     });
   });
 });
diff --git a/lighthouse-core/test/results/artifacts/artifacts.json b/lighthouse-core/test/results/artifacts/artifacts.json
@@ -12410,6 +12410,7 @@
         "deprecationType": "XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload"
       }
     ],
+    "federatedAuthRequestIssue": [],
     "genericIssue": [],
     "heavyAdIssue": [],
     "lowTextContrastIssue": [],

diff --git a/package.json b/package.json
@@ -141,7 +141,7 @@
     "cpy": "^8.1.2",
     "cross-env": "^7.0.2",
     "csv-validator": "^0.0.3",
-    "devtools-protocol": "0.0.963043",
+    "devtools-protocol": "0.0.964215",
     "es-main": "^1.0.2",
     "eslint": "^8.4.1",
     "eslint-config-google": "^0.14.0",
@@ -214,7 +214,7 @@
     "yargs-parser": "^21.0.0"
   },
   "resolutions": {
-    "puppeteer/**/devtools-protocol": "0.0.963043"
+    "puppeteer/**/devtools-protocol": "0.0.964215"
   },
   "repository": "GoogleChrome/lighthouse",
   "keywords": [

diff --git a/third-party/chromium-synchronization/inspector-issueAdded-types-test.js b/third-party/chromium-synchronization/inspector-issueAdded-types-test.js
@@ -40,6 +40,7 @@ Array [
   "contentSecurityPolicyIssueDetails",
   "corsIssueDetails",
   "deprecationIssueDetails",
+  "federatedAuthRequestIssueDetails",
   "genericIssueDetails",
   "heavyAdIssueDetails",
   "lowTextContrastIssueDetails",

diff --git a/types/artifacts.d.ts b/types/artifacts.d.ts
@@ -559,6 +559,7 @@ declare module Artifacts {
     contentSecurityPolicyIssue: LH.Crdp.Audits.ContentSecurityPolicyIssueDetails[];
     corsIssue: LH.Crdp.Audits.CorsIssueDetails[];
     deprecationIssue: LH.Crdp.Audits.DeprecationIssueDetails[];
+    federatedAuthRequestIssue: LH.Crdp.Audits.FederatedAuthRequestIssueDetails[],
     genericIssue: LH.Crdp.Audits.GenericIssueDetails[];
     heavyAdIssue: LH.Crdp.Audits.HeavyAdIssueDetails[];
     lowTextContrastIssue: LH.Crdp.Audits.LowTextContrastIssueDetails[];

diff --git a/yarn.lock b/yarn.lock
@@ -3157,10 +3157,10 @@ detect-newline@^3.0.0:
   resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-3.1.0.tgz#576f5dfc63ae1a192ff192d8ad3af6308991b651"
   integrity sha512-TLz+x/vEXm/Y7P7wn1EJFNLxYpUD4TgMosxY6fAVJUnJMbupHBOncxyWUG9OpTaH9EBD7uFI5LfEgmMOc54DsA==
 
-devtools-protocol@0.0.901419, devtools-protocol@0.0.963043:
-  version "0.0.963043"
-  resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.963043.tgz#03a35b7df8bf5ee64b4c1f4f23ef5e8bd9293efb"
-  integrity sha512-yROi8O/R6ORwt1oIe5CnXWGZUL1FbbFdjl7hA73STeIeX0jpowZqZsgDBU6wQ3Vr+4M8vByq/dJLcgwZGke4Tw==
+devtools-protocol@0.0.901419, devtools-protocol@0.0.964215:
+  version "0.0.964215"
+  resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.964215.tgz#4e5b09f9b4478ef63076fa79bae9704442212f2b"
+  integrity sha512-7xjHbM16/gh0Y6OZK7viLyttNWfWTSm/gT2wDW98kyslYrUBRMcDkcfpjohmZDQMlEQj+S3xcm+5OYkMoUNEDg==
 
 diff-sequences@^27.4.0:
   version "27.4.0"