Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to filter out URLs you don't want to be tested #468

Merged
merged 6 commits into from Oct 14, 2020

Conversation

JohnEidum
Copy link
Contributor

This PR allows you to filter out certain URLs that you would like to be skipped over during testing. This is used alongside staticDistDir and is not functional with url (Not sure how exactly that would end up working).

@google-cla
Copy link

google-cla bot commented Oct 13, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@JohnEidum
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 13, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@JohnEidum
Copy link
Contributor Author

@googlebot I fixed it.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @JohnEidum! this functionality sounds good, just some naming and code clarity points :)

packages/cli/src/collect/collect.js Outdated Show resolved Hide resolved
packages/cli/src/collect/collect.js Outdated Show resolved Hide resolved
@JohnEidum
Copy link
Contributor Author

Thank you! I have made the necessary changes. I chose to go with autodiscoverUrlBlocklist.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @JohnEidum 🎉

Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
@patrickhulce
Copy link
Collaborator

sorry @JohnEidum you have one more annoying snapshot to update with help text whitespace padding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants