feat(cli): log attempts to save url map

[chosak]

Related to #250.

[chosak]

I see why the tests are failing; because I've configured them to check for output from an upload, but that doesn't happen when GHA runs on non-master checks. @patrickhulce what's optimal behavior here -- to explicitly disable the upload (and roll back test changes), or maybe hardcode an explicit slug to use in the environment here?

[patrickhulce]

thanks very much @chosak this looks great! really appreciate you digging into this just a few nits on wording :)

[patrickhulce]

maybe hardcode an explicit slug to use in the environment here?

That seems like the best path forward, hardcode the use of GoogleChrome/lighthouse-ci-unit-tests as the slug and force the --uploadUrlMap flag?

[chosak]

Thanks for the text suggestions, I've fixed and rebased. I'll address your slug suggestion.

Aside: While doing that I noticed that some uses of "GitHub" (for example getGitHubRepoSlug, or the logging statements I've added) are perhaps overly specific, as one might potentially be running Lighthouse against repositories hosted on other source code providers. But maybe that's outside the scope of this PR.

[patrickhulce]

Those names are explicit because they're used for things that are github support only. We don't support any other providers and I consider it a bug that they can pickup anything other than github slugs :)

[patrickhulce]

thanks very much @chosak! 🎉

[chosak]

Thanks @patrickhulce!

Interesting side note I discovered while working on the tests -- some of these tests won't pass locally if your Git origin remote doesn't point to this repository (for example, I often use upstream for a project and then origin for my fork).

[patrickhulce]

some of these tests won't pass locally if your Git origin remote doesn't point to this repository (for example, I often use upstream for a project and then origin for my fork).

Ah yeah thanks for the note I'll loosen those! :)