Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transpileOptions prop to LiveProvider #260

Merged

Conversation

maksnester
Copy link
Contributor

Closes #252

Now it's possible to adjust buble transformations by passing transpileOptions prop to LiveProvider.

Example

    <LiveProvider
      transpileOptions={{
        transforms: {
          classes: false,
          asyncAwait: false
        }
      }}
   // ...

See the list of bubble transforms here: https://buble.surge.sh/guide/#command-line-options

@maksnester
Copy link
Contributor Author

Hey @jpdriver, could you please review this? I'm looking forward to seeing it published as 2.3.0 anytime soon 🙏

Copy link
Contributor

@jpdriver jpdriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @maksnester -- thanks very much for the PR.

code looks fine; we just need to update it following other changes to LiveProvider then we should be able to land this.

@maksnester maksnester force-pushed the mn/disable-transpilation-option branch from 63f30a0 to 08b945d Compare June 28, 2021 09:37
@maksnester
Copy link
Contributor Author

@jpdriver OK, updated. Works just fine and much simpler now 👍

@jpdriver jpdriver merged commit 34a6041 into FormidableLabs:master Jun 28, 2021
@jpdriver
Copy link
Contributor

now available via react-live@next, see Releases v2.3.0

@maksnester maksnester deleted the mn/disable-transpilation-option branch June 30, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable buble transpilation
2 participants