Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-react-context, fixes #221 #225

Merged
merged 2 commits into from Oct 3, 2020
Merged

Update create-react-context, fixes #221 #225

merged 2 commits into from Oct 3, 2020

Conversation

bkonkle
Copy link
Member

@bkonkle bkonkle commented Oct 1, 2020

  • create-react-context uses a version of fbjs that includes a vulnerable version of node-fetch.
  • This PR updates create-react-context to the latest version.
  • @storybook/react and @storybook/addon-knobs also use a version of fbjs that includes the vulnerable node-fetch version, but these are dev dependencies that should not impact production usage of react-live anywhere.

I tested by starting Storybook locally and ensuring that each case still renders as expected.

kitten
kitten approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already confirmed that a prior temporary licence change doesn't extend to this version anymore (it's probably been reverted)

@bkonkle bkonkle mentioned this pull request Oct 2, 2020
Closed
@jpdriver jpdriver merged commit 2d8246b into master Oct 3, 2020
@jpdriver jpdriver deleted the issue/221-update-create-react-context branch October 3, 2020 11:08
This was referenced Jun 6, 2021
Open
Open
Open
Closed
@renovate renovate bot mentioned this pull request Mar 14, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitten kitten kitten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkonkle @kitten @jpdriver