Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: excplicitely require direct dependency packageurl-js #1122

Merged
merged 3 commits into from Nov 11, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Nov 11, 2023

packageurl-js is a transitive dependency, that is true.
but it is also a direct dependency, see

import { type PackageURL } from 'packageurl-js'

Therefore, it is directly required, now

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added bug Something isn't working dependencies labels Nov 11, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner November 11, 2023 10:08
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e229098) 359 307 85.52%
Head commit (9302edb) 359 (+0) 307 (+0) 85.52% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1122) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@jkowalleck jkowalleck merged commit 53deef6 into main Nov 11, 2023
25 checks passed
@jkowalleck jkowalleck deleted the deps/bump-purl branch November 11, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant