Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use omit instead of exclude #162

Merged
merged 1 commit into from Nov 16, 2022
Merged

fix: Use omit instead of exclude #162

merged 1 commit into from Nov 16, 2022

Conversation

Gray-Wind
Copy link
Contributor

Exclude works with union types, here it seems should be omit

@Gray-Wind
fix: Use omit instead of exclude
8ca5686 
Exclude works with union types, here it seems should be omit
@ghost
Copy link

ghost commented Nov 16, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Jaryt
Copy link
Contributor

Jaryt commented Nov 16, 2022

Great find! Thank you 🙌

@Jaryt Jaryt merged commit 137e014 into CircleCI-Public:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaryt Jaryt Jaryt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gray-Wind @Jaryt