Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: agnostic config saving #157

Merged
merged 1 commit into from Nov 1, 2022
Merged

feat: agnostic config saving #157

merged 1 commit into from Nov 1, 2022

Conversation

KyleTryon
Copy link
Contributor

@KyleTryon KyleTryon commented Oct 31, 2022

fixes: #153

This change should allow for saving the config directly to a file without the user needing to configure external dependencies. This should work for both NodeJs and the browser.

Test coverage has fallen due to the new branch of file saving for browser which was not automatically tested here, looking into if we can do that with jest or is cypress needed

Note: saving with the browser requires user interaction
https://developer.mozilla.org/en-US/docs/Web/API/Window/showSaveFilePicker#security
image

@ghost
Copy link

ghost commented Oct 31, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 97.29% // Head: 96.15% // Decreases project coverage by -1.13% ⚠️

Coverage data is based on head (312252a) compared to base (871b65b).
Patch coverage: 27.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   97.29%   96.15%   -1.14%     
==========================================
  Files          61       61              
  Lines         665      676      +11     
  Branches       66       69       +3     
==========================================
+ Hits          647      650       +3     
- Misses          6       11       +5     
- Partials       12       15       +3     
Impacted Files Coverage Δ
src/lib/Config/index.ts 86.76% <27.27%> (-11.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Jaryt Jaryt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@KyleTryon KyleTryon merged commit 891c8d5 into main Nov 1, 2022
@KyleTryon KyleTryon deleted the feat/save branch November 1, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Add save to file functionality to config
2 participants