Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#154): Disable aliasDuplicateObjects by default #155

Merged
merged 3 commits into from Oct 26, 2022
Merged

feat(#154): Disable aliasDuplicateObjects by default #155

merged 3 commits into from Oct 26, 2022

Conversation

timo-reymann
Copy link
Contributor

Anchors are created by default to deduplicate parts of the generated YAML, which makes it harder to read.

Removing them makes pipelines more "human readable".

This closes #154.

Anchors are created by default to deduplicate parts of the generated YAML, which makes it harder to read.

Removing them makes pipelines more "human readable".
@ghost
Copy link

ghost commented Oct 26, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@KyleTryon
Copy link
Contributor

I was just noticing this yesterday. We used to have this off. I think when we pulled the parser out something changed. Thank you for this! I was semi-considering leaving it, as it makes the config smaller but i think less users are expecting to see it.

Thank you for the addition! Running tests now

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 97.58% // Head: 97.58% // No change to project coverage 👍

Coverage data is based on head (d8983ce) compared to base (29299f2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files          61       61           
  Lines         662      662           
  Branches       65       65           
=======================================
  Hits          646      646           
  Misses          5        5           
  Partials       11       11           
Impacted Files Coverage Δ
src/lib/Config/index.ts 98.24% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KyleTryon
Copy link
Contributor

Passed 👍 Going to merge this in now but we might hold off on a release for just a short while if this is non-critical, so that we can bundle a few more updates into the next feat release. Let us know if that's acceptable 👍.

Thanks again!

@KyleTryon KyleTryon merged commit 80c13b9 into CircleCI-Public:main Oct 26, 2022
@timo-reymann
Copy link
Contributor Author

Not critical, just a more cosmetic thing. Thanks for merging! :)

@timo-reymann timo-reymann deleted the feat/154-disable-anchors-by-default branch October 26, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Disable aliasDuplicateObjects by default
2 participants