Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(executor): fix generateContents method #149

Merged
merged 1 commit into from Oct 12, 2022
Merged

fix(executor): fix generateContents method #149

merged 1 commit into from Oct 12, 2022

Conversation

tapesec
Copy link
Contributor

@tapesec tapesec commented Sep 30, 2022

This commit fixes an issue that prevents the configuration from being generated for multiple images.

@ghost
Copy link

ghost commented Sep 30, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@tapesec tapesec mentioned this pull request Oct 3, 2022
Closed
4 tasks
@KyleTryon
Copy link
Contributor

Apologies for the wait @tapesec. Highly appreciate your help/contribution. Shipping this out right now.

@KyleTryon KyleTryon merged commit 29299f2 into CircleCI-Public:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleTryon KyleTryon KyleTryon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tapesec @KyleTryon