New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker layer caching support on machine executors #147
Conversation
👇 Click on the image for a new way to code review
Legend |
1616a42
to
c1727e0
Compare
Hey @a-cordier Thanks for the contribution! Docker Layer Caching is actually available on the Docker Container as well: https://circleci.com/docs/docker-layer-caching We probably could do some very advanced typescript stuff to make it so that you require the CC @Jaryt for opinion as well. |
@KyleTryon Thanks for the prompt review ! Does the docker_layer_caching property applies to (MacOS|Windows) executors ? I can see that they both extend the Executor class. |
Just figured out that dlc is implemented with a command for docker executors. I've updated the PR to add dlc support on the command as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done 👏 . And thank you for looking into the config reference to resolve this. I had to double check that myself. I am starting the tests now.
edit: oops, just noticed the branch is out of date. Going to update that first, fingers crossed for no conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should resolve the linting errors. Minor differences between JSDoc and TSDoc.
https://app.circleci.com/pipelines/github/CircleCI-Public/circleci-config-sdk-ts/439/workflows/7a9acf7c-28ec-410e-9a49-46888efbb375/jobs/2299
src/lib/Components/Commands/exports/Native/SetupRemoteDocker.ts
Outdated
Show resolved
Hide resolved
src/lib/Components/Commands/exports/Native/SetupRemoteDocker.ts
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 97.26% // Head: 97.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 97.26% 97.28% +0.02%
==========================================
Files 61 61
Lines 658 663 +5
Branches 64 65 +1
==========================================
+ Hits 640 645 +5
Misses 7 7
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
see #146