Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not resolve anchor, add type to resolveUrl #204

Merged
merged 1 commit into from Jun 23, 2022

Conversation

adamdbradley
Copy link
Contributor

Previously <a href> urls were resolved by a user's resolveUrl() config. This change will no longer have an anchor element's href resolved with the user config.

Additionally, all calls to a user's resolveUrl() will now include a third argument of the resource type, such as fetch, xhr or script.

resolveUrl(url: URL, location: Location, type: ResolveUrlType): URL | undefined | null;

@vercel
Copy link

vercel bot commented Jun 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
partytown ✅ Ready (Inspect) Visit Preview Jun 22, 2022 at 6:47PM (UTC)

@steve8708
Copy link
Contributor

🎉 !

steve8708 added a commit that referenced this pull request Jun 22, 2022
@adamdbradley adamdbradley merged commit f6d3303 into main Jun 23, 2022
@adamdbradley adamdbradley deleted the resolve-source branch June 23, 2022 13:07
adamdbradley pushed a commit that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants