-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration to run specific scripts on main thread #200
feat: add configuration to run specific scripts on main thread #200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for the review @khuezy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I'm not a code owner so I don't think my approval would be sufficient.
881c589
to
ecb0206
Compare
@steve8708 Any chance I could get a review, please? |
Absolutely, @adamdbradley is crunching on a major release for Qwik City and then can hop in here for a review |
Hello, thank you so much for taking this on @DanBeckDev. We want to use PartyTown on wonderbly.com but are blocked by this issue. If @steve8708 or @adamdbradley is able to take a look at this feature so it can be released we would be very grateful - I'm sure this would be useful for many others as well. |
This is great, thanks! |
Feature as requested by: #161
It was originally suggested that the configuration should look like this:
I have created it as an array:
This is because when the function gets serialized the function is a string and cannot execute.
If we wish to proceed with the idea above I am happy to extend the serialisation functionality but I deem it overkill myself.