Include third-party cookies when fetching images #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Partytown does not attach third-party cookies when fetching images. This breaks facebook pixel - take a look at the screen recording below.
On the left I have Facebook's 'Test events' tool. On the right NextJS app with Facebook Pixel added through GTM running within Partytown 😅
partytown-img.mp4
In addition to missing
credentials: 'include'
, I noticed that Image constructor never setssrc
attribute, I fixed it.