fix: createEnvironment in createHTMLDocument (#177)

BuilderIO · Jun 1, 2022 · 9c0ef6f · 9c0ef6f · vercel · Jun 1, 2022
1 parent 351a7a7
commit 9c0ef6f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 9 deletions.
diff --git a/src/lib/web-worker/worker-document.ts b/src/lib/web-worker/worker-document.ts
@@ -178,11 +178,12 @@ export const patchDocument = (
             callMethod(this, ['implementation', 'createHTMLDocument'], [title], CallType.Blocking, {
               $winId$,
             });
-            const docEnv = createWindow(
-              $winId$,
-              $winId$,
-              env.$location$ + '',
-              'hidden',
+            const docEnv = createEnvironment({
+                $winId$,
+                $parentWinId$: $winId$,
+                $url$: env.$location$ + '',
+                $visibilityState$: 'hidden',
+              },
               true,
               true
             );

diff --git a/src/lib/web-worker/worker-environment.ts b/src/lib/web-worker/worker-environment.ts
@@ -6,7 +6,7 @@ import { logWorker, normalizedWinId } from '../log';
 
 export const createEnvironment = (
   { $winId$, $parentWinId$, $url$, $visibilityState$ }: InitializeEnvironmentData,
-  isIframeWindow?: boolean
+  isIframeWindow?: boolean, isDocumentImplementation?: boolean
 ) => {
   if (!environments[$winId$]) {
     // create a simulated global environment for this window
@@ -16,7 +16,8 @@ export const createEnvironment = (
       $parentWinId$,
       $url$,
       $visibilityState$,
-      isIframeWindow
+      isIframeWindow,
+      isDocumentImplementation
     );
 
     if (debug) {

diff --git a/tests/platform/document/document.spec.ts b/tests/platform/document/document.spec.ts
@@ -92,7 +92,7 @@ test('document', async ({ page }) => {
   await expect(testCreateElementError_).toHaveText('no error');
 
   const testCreateHTMLDocument = page.locator('#testCreateHTMLDocument');
-  await expect(testCreateHTMLDocument).toHaveText('88mph hidden');
+  await expect(testCreateHTMLDocument).toHaveText('88mph hidden object');
 
   const testVisibilityState = page.locator('#testVisibilityState');
   await expect(testVisibilityState).toHaveText('visible');

diff --git a/tests/platform/document/index.html b/tests/platform/document/index.html
@@ -432,9 +432,13 @@ <h1 class="title">Document</h1>
         <script type="text/partytown">
           (function () {
             const doc = document.implementation.createHTMLDocument();
-            doc.body.textContent = '88mph ' + doc.visibilityState;
 
             const elm = document.getElementById('testCreateHTMLDocument');
+
+            const addlElm = doc.createElement('base');
+            const addlElmType = typeof addlElm;
+
+            doc.body.textContent = '88mph ' + doc.visibilityState + ' ' + addlElmType;
             elm.textContent = doc.body.textContent;
           })();
         </script>