fix: Include third-party cookies when fetching images (#182)

* fix: include third-party cookies when fetching images * fix: set src property on Image instance * test: verify that img.src is set
BuilderIO · May 24, 2022 · 90c43a2 · 90c43a2 · vercel · May 24, 2022
1 parent e6260a0
commit 90c43a2
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/src/lib/web-worker/worker-image.ts b/src/lib/web-worker/worker-image.ts
@@ -24,8 +24,11 @@ export const createImageConstructor = (env: WebWorkerEnvironment) =>
         logWorker(`Image() request: ${resolveUrl(env, src)}`, env.$winId$);
       }
 
+      this.s = src;
+
       fetch(resolveUrl(env, src, true), {
         mode: 'no-cors',
+        credentials: 'include',
         keepalive: true,
       }).then(
         (rsp) => {

diff --git a/tests/platform/image/image.spec.ts b/tests/platform/image/image.spec.ts
@@ -34,4 +34,8 @@ test('image', async ({ page }) => {
   await page.waitForSelector('.testImgListenerError');
   const testImgListenerError = page.locator('#testImgListenerError');
   await expect(testImgListenerError).toHaveText('error');
+
+  await page.waitForSelector('.testImgSrc');
+  const testImgSrc = page.locator('#testImgSrc');
+  await expect(testImgSrc).toHaveText('dot.gif?imageSrcTest');
 });
diff --git a/tests/platform/image/index.html b/tests/platform/image/index.html
@@ -183,6 +183,22 @@ <h1>Image</h1>
           })();
         </script>
       </li>
+
+      <li>
+        <strong>&lt;img&gt; src</strong>
+        <code id="testImgSrc"></code>
+        <script type="text/partytown">
+          (function () {
+            const image = new Image();
+            image.src = 'dot.gif?imageSrcTest';
+            image.onload = function (ev) {
+              const elm = document.getElementById('testImgSrc');
+              elm.textContent = image.src;
+              elm.className = 'testImgSrc';
+            };
+          })();
+        </script>
+      </li>
     </ul>
 
     <hr />