Repro issue with cast errors not persisting across validation

Automattic · Mar 19, 2015 · 5371e36 · 5371e36
1 parent ad4462c
commit 5371e36
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/test/document.test.js b/test/document.test.js
@@ -1040,12 +1040,37 @@ describe('document', function(){
 
       var m = new M({ _id: 'this is not a valid _id' });
       assert.ok(!m.$isValid('_id'));
+      assert.ok(m.validateSync().errors['_id'].name, 'CastError');
+
       m._id = '000000000000000000000001';
       assert.ok(m.$isValid('_id'));
+      assert.ifError(m.validateSync());
       m.validate(function(error) {
         assert.ifError(error);
         db.close(done);
+      });
+    });
+
+    it('cast errors persist across validate() calls (gh-2766)', function(done) {
+      var db = start();
+      var testSchema = new Schema({ name: String });
+      var M = db.model('gh2766', testSchema);
 
+      var m = new M({ _id: 'this is not a valid _id' });
+      assert.ok(!m.$isValid('_id'));
+      m.validate(function(error) {
+        assert.ok(error);
+        assert.equal(error.errors['_id'].name, 'CastError');
+        m.validate(function(error) {
+          assert.ok(error);
+          assert.equal(error.errors['_id'].name, 'CastError');
+
+          var err1 = m.validateSync();
+          var err2 = m.validateSync();
+          assert.equal(err1.errors['_id'].name, 'CastError');
+          assert.equal(err2.errors['_id'].name, 'CastError');
+          db.close(done);
+        });
       });
     });
 

diff --git a/test/types.buffer.test.js b/test/types.buffer.test.js
@@ -72,8 +72,9 @@ describe('types.buffer', function(){
         t.save(function (err) {
           assert.ok(err);
           assert.equal(err.name, 'ValidationError');
-          assert.equal(err.errors.required.kind, 'cast');
-          assert.equal(err.errors.required.message, 'Cast to buffer failed for value "[object Object]" at path "required"');
+          assert.equal(err.errors.required.name, 'CastError');
+          assert.equal(err.errors.required.kind, 'Buffer');
+          assert.equal(err.errors.required.message, 'Cast to Buffer failed for value "[object Object]" at path "required"');
           assert.deepEqual(err.errors.required.value, {x:[20]});
           t.required = new Buffer("hello");